fix: debounce while(true) in CheckThreadSafetyMojo PMD-Rule: EmptyControlStatement
#2370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraz76
force-pushed
the
EmptyControlStatement-CheckThreadSafetyMojo
branch
from
a32fd7a to
93afe81
Compare
Pankraz76
commented
May 21, 2025
...in-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java
Show resolved
Hide resolved
Pankraz76
changed the title
CheckThreadSafetyMojoCheckThreadSafetyMojo PMD-Rule: EmptyControlStatement
elharo
requested changes
May 22, 2025
...in-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java
Outdated
Show resolved
Hide resolved
Pankraz76
force-pushed
the
EmptyControlStatement-CheckThreadSafetyMojo
branch
from
93afe81 to
86b57c2
Compare
Pankraz76
changed the title
CheckThreadSafetyMojo PMD-Rule: EmptyControlStatementwhile(true) in CheckThreadSafetyMojo PMD-Rule: EmptyControlStatement
Pankraz76
changed the title
while(true) in CheckThreadSafetyMojo PMD-Rule: EmptyControlStatementwhile(true) in CheckThreadSafetyMojo PMD-Rule: EmptyControlStatement
gnodet
reviewed
May 23, 2025
...in-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java
Show resolved
Hide resolved
Pankraz76
commented
Jun 3, 2025
| while (go.isEmpty()) { | ||
| // wait for start | ||
| try { | ||
| Thread.sleep(100); // wait for the start |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| Thread.sleep(100); // wait for the start | |
| MILLISECONDS.sleep(100); // wait for the start |
https://docs.oracle.com/javase/9/docs/api/java/util/concurrent/TimeUnit.html#sleep-long-
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while(true)withCountDownLatchinCheckThreadSafetyMojo#2381